5098: Add additional RpcErrorTypes for invalid parameters #7389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
…InvalidRlp() Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
…-for-invalid-params
Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
…icular-cases-for-invalid-params' into 5098-add-detail-messages-to-particular-cases-for-invalid-params
…s time Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
…-for-invalid-params
|
This PR is good for improving the UX, but a bit too large to be easily reviewed, I suggest to split it in smaller chunks, maybe by grouping similar error type in specific PRs so it is easier to reason about the change. |
…-for-invalid-params
|
Closing this PR to attempt a more piecemeal approach |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Adds additional RpcErrorTypes to provide extra context around invalid parameters. I recommend starting review with changes in RpcErrorType and InvalidJsonRpcParameters, as these changes lay the foundation for the remainder of the changes.
Fixed Issue(s)
#5098
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests